Fix backwards-incompatible CLI change #2077
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Patch cd04992 changed the name of the `esplora` CLI argument to `electrs` for correctness. But the change was introduced in a backwards-incompatible manner. This patch solves that issue by introducing an alias for the CLI argument with the original name. All this applies to both the coordinator and the webapp.
|
Tested locally and it works. Merging to be able to use this ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Patch cd04992 changed the name of the
esploraCLI argument toelectrsfor correctness. But the change was introduced in a backwards-incompatible manner.This patch solves that issue by introducing an alias for the CLI argument with the original name.
All this applies to both the coordinator and the webapp.