feat(webapp/app): show pnl as percent #2221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philipp Hoenisch <[email protected]>
holzeis
approved these changes
Mar 12, 2024
| @@ -70,6 +71,10 @@ class _PositionListItemState extends State<PositionListItem> { | |||
|
|
|||
| TextStyle dataRowStyle = const TextStyle(fontSize: 14); | |||
|
|
|||
| Amount? unrealizedPnl = notNullPosition.unrealizedPnl; | |||
| double pnlPercent = | |||
| ((unrealizedPnl?.sats ?? Amount.zero().sats) / notNullPosition.collateral.sats) * 100.0; | |||
There was a problem hiding this comment.
🔧 we should probably round here to 2 numbers after the comma.
There was a problem hiding this comment.
Thanks for pointing this out.
It's done when the pnlPercent is being used with toStringAsFixed(2). (I initially used the wrong function, but now it's correct).
Signed-off-by: Philipp Hoenisch <[email protected]>
bonomat
force-pushed
the
feat/pnl-percent
branch
from
39de90d
to
c44ab0d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2187
App:
Webapp: