chore: Wait for current context to get available when showing recover dlc dialog #2265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the app was closed when an order got filled, the pending order is not set anymore. This fixes ``` flutter: [INFO] TIME: 2024-03-18T08:02:02.796655Z r: Updated order state new_state: Filled,order_id: 95a65da8-fe2e-48ab-847d-dab47dac7b49 [ERROR:flutter/runtime/dart_vm_initializer.cc(41)] Unhandled Exception: Null check operator used on a null value #0 SubmitOrderChangeNotifier.notify (package:get_10101/features/trade/submit_order_change_notifier.dart:105:24) #1 new EventService.create.<anonymous closure> (package:get_10101/common/application/event_service.dart:21:20) #2 _RootZone.runUnaryGuarded (dart:async/zone.dart:1594:10) #3 _BufferingStreamSubscription._sendData (dart:async/stream_impl.dart:339:11) #4 _BufferingStreamSubscription._add (dart:async/stream_impl.dart:271:7) #5 _SyncStreamControllerDispatch._sendData (dart:async/stream_controller.dart:784:19) #6 _StreamController._add (dart:async/stream_controller.dart:658:7) #7 _StreamController.add (dart:async/stream_controller.dart:606:5) #8 _AsyncStarStreamController.add (dart:async-patch/async_patch.dart:76:16) #9 FlutterRustBridgeBase.executeStream (package:flutter_rust_bridge/src/basic.dart) <asynchronous suspension> #10 ne<…> ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes some issues with the recover dialog being displayed after the app got closed in the middle of a protocol.
fixes #2262
fixes #2263 (169ad6b)