chore(api)!: Refactor limit and market order models #2316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bonomat
force-pushed
the
chore/refactorings
branch
2 times, most recently
from
245570c
to
caaff84
Compare
holzeis
approved these changes
Mar 25, 2024
| @@ -262,7 +289,7 @@ pub fn insert_limit_order( | |||
| pub fn insert_market_order( | |||
| conn: &mut PgConnection, | |||
| // TODO: use market order here | |||
There was a problem hiding this comment.
🔧 you can remove the todo now :)
| @@ -16,10 +16,10 @@ impl OrderbookClient { | |||
| Self { url } | |||
| } | |||
|
|
|||
| pub(crate) async fn post_new_order( | |||
| pub(crate) async fn post_new_market_order( | |||
| &self, | |||
| // TODO: use market order | |||
There was a problem hiding this comment.
🔧 you can remove the todo now :)
| bool marginInputFieldEnabled = false; | ||
| bool quantityInputFieldEnabled = true; | ||
|
|
||
| // Amount quantity = Amount(sats); |
bonomat
changed the title
bonomat
force-pushed
the
chore/refactorings
branch
from
caaff84
to
92364c6
Compare
We move the differentiation of the order type one level up by changing the api to handle an enum. This way we can have different fields for different types of orders without having to have lots of nullable values, e.g. Market, Limit but also others such as Margin (which tells how much margin to use), StopLoss, TakeProfit, etc.
We should probably introduce a `Quantity` type if we want to support different contracts. For now, a contract equals $1, hence, USD is correct.
this will allow us to differentiate between newOrders and Orders
bonomat
force-pushed
the
chore/refactorings
branch
from
92364c6
to
4149538
Compare
holzeis
changed the title
holzeis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracted from #2282