Ensure that wallet history text does not overflow #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least on Linux, when running `just run` I would consistently get warnings directly on the UI on every wallet history item. Each one would say `Bottom overflowed by 6.0 pixels`. This is annoying when developing, but I believe it's also a sign that we were doing something wrong. Hence this fix.
|
Left without these changes and right with them. to be honest I don't think reducing the font size is an improvement on the phone.
|
holzeis
reviewed
Jul 5, 2023
|
It does look pretty terrible on the phone, what a shame. Thanks for testing it out, @holzeis. |
|
@luckysori perhaps you're missing some fonts and the substitutes are different size? this does not happen on desktop of macOS. |
Could be! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At least on Linux, when running
just runI would consistently get warnings directly on the UI on every wallet history item. Each one would sayBottom overflowed by 6.0 pixels. This is annoying when developing, but I believe it's also a sign that we were doing something wrong. Hence this fix.Before:
After: