Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(justfile): Improve just coordinator-detached #911

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

klochowicz
Copy link
Contributor

Wait for coordinator to actually start before stating that it started successfully.

Note: We can't do this with maker for now, as there's no HTTP API there yet.

Wait for coordinator to actually start before stating that it started successfully.

Note: We can't do this with maker for now, as there's no HTTP API there yet.
@klochowicz klochowicz requested review from luckysori and holzeis and removed request for luckysori July 6, 2023 01:45
@klochowicz klochowicz self-assigned this Jul 6, 2023
@klochowicz klochowicz requested a review from Restioson July 6, 2023 01:53
Copy link
Contributor

@luckysori luckysori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@klochowicz
Copy link
Contributor Author

bors r+

@bors
Copy link
Contributor

bors bot commented Jul 6, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 776acb3 into main Jul 6, 2023
7 checks passed
@bors bors bot deleted the chore/improve-run-coordinator-detached branch July 6, 2023 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants