Calculate and display open-channel fee estimate #921
Conversation
|
Note: The info message as one text blob is not optimal - we could optimize this and highlight certain parts. I tried to keep the text short - if you have suggestions on how to shorten it more please add suggestions! |
|
I think it would be great to come to a conclusion for https://github.com/get10101/meta/issues/178 on top of this work. |
The trade minimum is not the same as the receive minimum so the message may read weird if we already have a balance.
It's nice for the user to have this information there. This is in preparation for displaying additional fees.
By passing in a widget as child from the outside we can use this info model more flexible.
If we don't have a `ChannelInfo` yet we know this is an initial channel open and estimate the channel opening fee. The fee information is based on a transaction weight estimate of `220` for the funding transaction estimate with two inputs. For most users this will likely be cheaper because only one UTXO will be used but it's better to safe funds than to have to pay more. If we have a fee on record when creating an invoice we add this fee to the minimum receive value to ensure the user will be able to pay the fee and trade. We pass a potential fee on to the share invoice screen where the fee is displayed including an info button that pops up an explanatory modal.
|
bors r+ |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
fixes https://github.com/get10101/meta/issues/172
Please note: The screen font may look a bit odd for you because my default test setup is iPhone SE (3rd gen) with Accessibility Large, Bold Text activated to ensure that the screen does not break (unless users somehow increase the font even more, not sure if that is possible):