chore: Use network specific quotes everywhere #996
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da-kami
approved these changes
Jul 25, 2023
|
Not against it but it will mess with our hedging strategy. |
|
Alternatively, we can also use the testnet quotes consistently. e.g. the candlestick chart always shows mainnet prices. Also the testnet quotes do not change that often, thats why I sometime thought the maker was down. |
If this bothers you, I'd rather go for showing a different candle chart. |
holzeis
force-pushed
the
chore/subscribe-to-mainnet-quotes
branch
from
8943f21
to
399aeea
Compare
holzeis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the correct quotes consistently on the coordinator and app depending on the network.
// edit: updated description due to a changed solution approach.