feat: show pending and failed transactions for nwc #3292
Conversation
|
New and removed dependencies detected. Learn more about Socket for GitHub ↗︎
🚮 Removed packages: npm/@getalby/[email protected], npm/@noble/[email protected], npm/@noble/[email protected], npm/[email protected], npm/[email protected], npm/[email protected] |
pavanjoshi914
requested review from
reneaaron,
rolznz and
im-adithya
and removed request for
reneaaron,
rolznz and
im-adithya
src/extension/background-script/connectors/connector.interface.ts
Outdated
Show resolved
Hide resolved
| @@ -31,10 +31,12 @@ export interface ConnectorTransaction { | |||
| /** | |||
| * Settle date in UNIX milliseconds | |||
| */ | |||
| settleDate: number; | |||
| settleDate: number | null; | |||
| creationDate?: number; | |||
There was a problem hiding this comment.
which connectors do not have a creation date? can't this be taken from the bolt11 invoice?
There was a problem hiding this comment.
all other connectors only pass settled transactions and we don't even need creationDate for them except for nwc. so i kept it optional and passed this field only for nwc connector. maybe we can be consistent accross and pass it for all now
There was a problem hiding this comment.
for commando there is no creation date passed via api. https://docs.corelightning.org/reference/lightning-listinvoices
There was a problem hiding this comment.
it can be taken from the bolt11 invoice, can't it?
| @@ -128,7 +128,7 @@ export default class LaWallet implements Connector { | |||
| return { | |||
| data: { | |||
| transactions: parsedTransactions.sort( | |||
| (a, b) => b.settleDate - a.settleDate | |||
| (a, b) => (b.settleDate ?? 0) - (a.settleDate ?? 0) | |||
There was a problem hiding this comment.
I don't think this connector should be affected like this in this PR? if lawallet only has settled transactions, there is now extra code that does not even apply.
Can't you sort the transactions before mapping them?
There was a problem hiding this comment.
that was just to make typescript happy we have common type definitions for all the connectors. now settleDate can be either number | null (cause of nwc pending and failed transactions). any better approach here?
There was a problem hiding this comment.
Can't you sort the transactions before mapping them?
pavanjoshi914
force-pushed
the
nwc-transaction-states
branch
from
f245ef1 to
c44add1
Compare
show failed and pending transactions for nwc
Fixes #3291
