fix: add composite index for summing payments #140
Conversation
|
Will this update the current DB, too? is this a migration? |
|
@bumi it's an automatic migration. So we create an index for all 4 fields, should we still add indexes for the individual columns too? |
|
@bumi updated |
rolznz
changed the title
| Preimage string | ||
| CreatedAt time.Time | ||
| Preimage string `gorm:"index:idx_payment_sum"` | ||
| CreatedAt time.Time `gorm:"index:idx_payment_sum"` |
There was a problem hiding this comment.
is idx_ a convention we follow here?
There was a problem hiding this comment.
This is the first gorm composite index. I am happy to change it, do you have a suggestion?
| App App `gorm:"constraint:OnDelete:CASCADE"` | ||
| NostrEventId uint `gorm:"index" validate:"required"` | ||
| NostrEvent NostrEvent | ||
| Amount uint | ||
| Amount uint `gorm:"index:idx_payment_sum"` |
There was a problem hiding this comment.
I think the amount in the index does not make sense to have the amount part of the index we do not query for that.
we do WHERE app_id = ? AND preimage IS NOT ? AND created_at > ?
so maybe we do the 3 in the index and include the amount that then can be used to sum things up.
https://atlasgo.io/guides/postgres/included-columns
|
Replaced by #148 |
fixes #140
improves performance of query to sum payments in current budget period