Removed platform-config #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed the platform configuration part as it unnecessarily constrains the installation of dependencies.
A plugin name must not start with a numeric character to avoid illegal class names.
|
Also added a validation check on the |
Karmalakas
reviewed
Jun 3, 2023
classes/DevToolsCommand.php
Outdated
| if ($value === null || trim($value) === '') { | ||
| throw new \RuntimeException('Name cannot be empty'); | ||
| } | ||
|
|
||
| // Check if name starts with a numeric character | ||
| if (is_numeric($value[0])) { | ||
| throw new \RuntimeException('Name must start with a alphanumeric character [a-z|A-Z]'); |
There was a problem hiding this comment.
I assume it's meant to be just an alpha instead of alphanumeric :)
There was a problem hiding this comment.
Thanks for spotting! That was a typo.
An updates PR is in the making.
|
Cheers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the platform configuration part as it unnecessarily constrains the installation of dependencies. As adviced by Ole Vik after research by pamtbaau, see Grav Forum post Unable to use third party library in new plugin