Skip to content

Commit

Permalink
Reinstatiate javadoc step in common build (#102)
Browse files Browse the repository at this point in the history
* Reinstatiate javadoc step in common build

* Fix <br> tag for javadoc
  • Loading branch information
MarekMaj authored Jun 7, 2024
1 parent 5a6e7bf commit 9bfbb4c
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 11 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ jobs:
- name: Test JavaDoc
run: mvn $MAVEN_CLI_OPTS $JAVA_ADDITIONAL_OPTS javadoc:javadoc
if: startsWith(matrix.flink, '1.15.0')
if: startsWith(matrix.flink, '1.18')

- name: Add coverage to PR
id: jacoco
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,17 @@
* other factories in
* <pre>resources/META-INF/services/org.apache.flink.table.factories.Factory</pre>
* file and then referenced by their identifiers in:
* <li>
* The HttpSink DDL property field <i>gid.connector.http.sink.request-callback</i>
* for HTTP sink.
* </li>
* <li>
* The Http lookup DDL property field <i>gid.connector.http.source.lookup.request-callback</i>
* for HTTP lookup.
* </li>
*
* <br />
* <ul>
* <li>
* The HttpSink DDL property field <i>gid.connector.http.sink.request-callback</i>
* for HTTP sink.
* </li>
* <li>
* The Http lookup DDL property field <i>gid.connector.http.source.lookup.request-callback</i>
* for HTTP lookup.
* </li>
* </ul>
* <br>
*
* <p>The following example shows the minimum Table API example to create a {@link HttpDynamicSink}
* that uses a custom callback created by a factory that returns <i>my-callback</i> as its
Expand Down

0 comments on commit 9bfbb4c

Please sign in to comment.