HTTP-121 Ensure SerializationSchema is used in thread-safe way #127
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
MarekMaj
reviewed
Oct 10, 2024
...data/connectors/http/internal/table/lookup/querycreators/GenericJsonQueryCreatorFactory.java
Outdated
Show resolved
Hide resolved
|
|
grzegorz8
force-pushed
the
fix/121-serialization-schema-thread-safety
branch
from
d0a4ae7 to
dc57ffe
Compare
kristoffSC
approved these changes
Oct 13, 2024
grzegorz8
force-pushed
the
fix/121-serialization-schema-thread-safety
branch
from
dc57ffe to
67c618b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Async lookup queries may return incorrect results because
org.apache.flink.formats.json.JsonRowDataSerializationSchemais not thread-safe. In this PR I introduce a temporary fix, which ensures that SerializationSchema is used in thread-safe way. In long-term we should refactor the code so that serialization can be safely run in parallel.Resolves
HTTP-121.PR Checklist