Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue 64 add junit 5 support #72

Merged
merged 1 commit into from
Mar 27, 2024
Merged

Conversation

davidradl
Copy link
Contributor

@davidradl davidradl commented Mar 4, 2024

Description

Add junit 5 support - so tests can run against Flink 1.17 and 1.18
Resolves #64

PR Checklist
  • Tests added (enabled tests)
  • Changelog updated

@kristoffSC
Copy link
Collaborator

checking

@kristoffSC
Copy link
Collaborator

checking.

@kristoffSC
Copy link
Collaborator

Hi @davidradl
Please try this patch on your branch and let me know what are the results

Flink1.16.patch

@davidradl davidradl marked this pull request as draft March 21, 2024 16:58
@kristoffSC
Copy link
Collaborator

kristoffSC commented Mar 21, 2024

I see thatbuild fails with below exception

Error: 9,649 [ERROR]   HttpSinkConnectionTest.testFailedConnection:238 expected: <1> but was: <0>
Error: 9,649 [ERROR]   HttpSinkConnectionTest.testServerErrorConnection:202 expected: <1> but was: <0>

It is an improvement comparing to previous thing where thre was classNoFound ;)
I will take a look at those two tests, maybe I will find what causing the issue here.

UPDATE:
This is working on Flink 1.16.3 interesting i bet we are doing something wrong in test for metric gathering.

@davidradl
Copy link
Contributor Author

I see thatbuild fails with below exception

Error: 9,649 [ERROR]   HttpSinkConnectionTest.testFailedConnection:238 expected: <1> but was: <0>
Error: 9,649 [ERROR]   HttpSinkConnectionTest.testServerErrorConnection:202 expected: <1> but was: <0>

It is an improvement comparing to previous thing where thre was classNoFound ;) I will take a look at those two tests, maybe I will find what causing the issue here.

UPDATE: This is working on Flink 1.16.3 interesting i bet we are doing something wrong in test for metric gathering.

@kristoffSC thanks let me know how you get on.

@davidradl
Copy link
Contributor Author

this pr may address #73

@kristoffSC
Copy link
Collaborator

Hi @davidradl
Please apply attached patch on top of what you have currently on this branch.
This should do the job.

I've ran local builds against Flink 1.16, 17 and 18 they all passing.

Flink1.16_b.patch

@kristoffSC kristoffSC self-requested a review March 23, 2024 22:00
@kristoffSC kristoffSC added the enhancement New feature or request label Mar 23, 2024
@davidradl davidradl marked this pull request as ready for review March 25, 2024 22:19
@davidradl
Copy link
Contributor Author

@kristoffSC It is working - thanks for the patches - I have squashed the commits. I think we are ready to merge.

@davidradl davidradl mentioned this pull request Mar 25, 2024
@kristoffSC kristoffSC merged commit dacf108 into getindata:main Mar 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check Flink 1.17 compatibility
2 participants