fix: hide stage in URL in REST scenario #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnapoli
approved these changes
Sep 29, 2023
|
@mnapoli @fredericbarthelet is there anything I can do to push this forward? 😊 |
|
Would love to se this merged! |
|
All good thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to solve #364. The issue is that the stage needs to be appended to the URL in REST scenario in order to view the deployed app. By using
originPathof the CloudFront distribution we can hide it from the user so he can simply access the CloudFront URL/custom domain.This is my first time working on a serverless plugin so I hope I used the correct approach. Please me know if I should change anything.