Resolve coverage dependency conflict #4191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bblommers
force-pushed
the
resolve-coverage-dep-conflict
branch
2 times, most recently
from
fca7cbe to
37abb53
Compare
bblommers
force-pushed
the
resolve-coverage-dep-conflict
branch
from
37abb53 to
bb9c103
Compare
Codecov Report
@@ Coverage Diff @@
## master #4191 +/- ##
==========================================
- Coverage 95.07% 95.07% -0.01%
==========================================
Files 480 480
Lines 52892 53031 +139
==========================================
+ Hits 50288 50419 +131
- Misses 2604 2612 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
This is now part of moto >= 2.2.4.dev5 |
sahilshah6196
pushed a commit
to EBSCOIS/moto
that referenced
this pull request
Dec 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #4083
Fixes #4190
Relates to pypa/pip#10201
Our coverage-dependency was unresolvable, with
pytest-covrequiringcoverage>5, but because of the XRay SDK we requiredcoverage<5.Before, pip would complain about it, but leave it up to us to figure it out. The new Pip resolver thinks it can fix it, but then takes literal hours trying to find a compatible set of dependencies.
Downgrading
pytest-covleads to an even bigger dependency hell, as it is quite tightly coupled with pytest itself.Installing the old version of
coverageseparately when running the CI is IMO the least-impactful solution.Contributors would not normally run
make test-coverageanyway - justmake test- so this should not impact anyone.