fix: extend telnet timeout for connection #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchelkowski
requested review from
tbazelczuk and
shirishapitta
and removed request for
a team
tbazelczuk
approved these changes
Nov 21, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Nov 21, 2023
## [2.3.2](v2.3.1...v2.3.2) (2023-11-21) ### Bug Fixes * extend telnet timeout for connection ([#45](#45)) ([3e60a3e](3e60a3e))
|
🎉 This PR is included in version 2.3.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What did you implement:
Extends telnet wait time to 60 seconds for an initial connection at the launch of the tests.
For some older devices in connection with some applications where there are already a lot of unit tests written which extends the size of the package by a significant amount, 20 seconds is not enough to launch the testing app.
Todos:
Is this ready for review?: YES
Is it a breaking change?: NO