Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add test and testEach functions #46

Merged
merged 2 commits into from
Dec 1, 2023

Conversation

bchelkowski
Copy link
Member

@bchelkowski bchelkowski commented Nov 28, 2023

What did you implement:

Added 2, new test functions:

  • test - same as it, but does not add "it " string at the beginning of test name
  • testEach - same as itEach, but does not add "it " string at the beginning of test name

Todos:

  • Write documentation (if required)
  • Fix linting errors
  • Enable "Allow edits from maintainers" for this PR
  • Update the messages below

Is this ready for review?: YES
Is it a breaking change?: NO

@bchelkowski bchelkowski requested a review from a team as a code owner November 28, 2023 11:04
@bchelkowski bchelkowski requested review from tbazelczuk and Borsuczio and removed request for a team November 28, 2023 11:04
@bchelkowski bchelkowski force-pushed the feat--add-test-and-testEach-functions branch from 47ab30f to a9720c0 Compare November 28, 2023 11:06
Copy link
Contributor

@pawelhertman pawelhertman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I realised in Jest for the "it" method they don't print "it" - "it" works exactly the same as "test" (and "it" is just mentioned in the docs, not fully described: https://jestjs.io/docs/api#testname-fn-timeout). Maybe we should do the same? 🤔

docs/api/KopytkoTestFunctions.md Show resolved Hide resolved
@bchelkowski
Copy link
Member Author

Jest does not do that, but I think it is better to read it with "it". Now you can use the test and testEach functions if you don't want to add "it to the beginning of the test name.

@bchelkowski bchelkowski merged commit 56f93c9 into master Dec 1, 2023
1 check passed
@bchelkowski bchelkowski deleted the feat--add-test-and-testEach-functions branch December 1, 2023 12:12
github-actions bot pushed a commit that referenced this pull request Dec 1, 2023
# [2.4.0](v2.3.2...v2.4.0) (2023-12-01)

### Features

* add test and testEach functions ([#46](#46)) ([56f93c9](56f93c9))
Copy link

github-actions bot commented Dec 1, 2023

🎉 This PR is included in version 2.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants