Remove extra subdef.id check

getodk · Oct 4, 2023 · 8c40f46 · 8c40f46
1 parent 7f59e5d
commit 8c40f46
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/lib/model/query/entities.js b/lib/model/query/entities.js
@@ -51,9 +51,9 @@ const createNew = (dataset, partial, subDef, sourceId, userAgentIn) => ({ one, c
   let userAgent;
 
   // Set creatorId and userAgent from submission def if it exists
-  if (subDef != null && subDef.id != null)
+  if (subDef != null) {
     ({ submitterId: creatorId, userAgent } = subDef);
-  else {
+  } else {
     creatorId = context.auth.actor.map((actor) => actor.id).orNull();
     userAgent = blankStringToNull(userAgentIn);
   }
@@ -94,9 +94,9 @@ const createVersion = (dataset, partial, subDef, version, sourceId, userAgentIn
   let userAgent;
 
   // Set creatorId and userAgent from submission def if it exists
-  if (subDef != null && subDef.id != null)
+  if (subDef != null) {
     ({ submitterId: creatorId, userAgent } = subDef);
-  else {
+  } else {
     creatorId = context.auth.actor.map((actor) => actor.id).orNull();
     userAgent = blankStringToNull(userAgentIn);
   }