Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add little empty structure unit test #1063

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Add little empty structure unit test #1063

merged 1 commit into from
Dec 13, 2023

Conversation

ktuite
Copy link
Member

@ktuite ktuite commented Dec 12, 2023

Followup to PR #1053

Another little test that SchemaStack is ok with fields that represent structures but have no children.

What has been done to verify that this works as intended?

Why is this the best possible solution? Were any other approaches considered?

How does this change affect users? Describe intentional changes to behavior and behavior that could have accidentally been affected by code changes. In other words, what are the regression risks?

Does this change require updates to the API documentation? If so, please update docs/api.md as part of this PR.

Before submitting this PR, please make sure you have:

  • run make test-full and confirmed all checks still pass OR confirm CircleCI build passes
  • verified that any code from external sources are properly credited in comments or that everything is internally sourced

@ktuite ktuite requested a review from matthew-white December 12, 2023 23:05
@ktuite ktuite merged commit 54ebb82 into master Dec 13, 2023
5 checks passed
@ktuite ktuite deleted the ktuite/empty_structure branch December 13, 2023 00:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants