feat: Change IGNORE_FILES setting default to all hidden files
#3424
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid subtle behaviour that contributed to root cause of pelican-plugins/sitemap#36 Specifically: if installing Pelican into a local virtualenv with the pdm or uv default name ".venv", then subdirectories of .venv will contain all of the test .rst and .md files. If you then run Pelican in that same root directory using the default PATH value (".") then it will add those content files to the site.
justinmayer
changed the title
IGNORE_FILES setting default to all hidden files
justinmayer
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid subtle behaviour that contributed to root cause of pelican-plugins/sitemap#36
Specifically: if installing Pelican into a local virtualenv with the pdm or uv default name ".venv", then subdirectories of .venv will contain all of the test .rst and .md files.
If you then run Pelican in that same root directory using the default PATH value (".") then it will add those content files to the site.
Pull Request Checklist
Resolves: #issue-number-here
(I haven't added a new test for the default setting, but I can if needed.)