Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Handle nil deployment outputs gracefully #71

Conversation

arunpnair
Copy link
Contributor

@arunpnair arunpnair commented Oct 2, 2024

What does this change

In ARM templates, the outputs element is used to return values from deployed resources, and its inclusion is optional. However, the current version of the arm-mixin incorrectly treats the outputs section as mandatory, generating an error when the ARM template being deployed does not define outputs section.

image

What issue does it fix

This pull request resolves the issue of arm-mixin deployment failures that occur when the ARM template lacks the outputs section. Furthermore, unit test cases have been added to ensure comprehensive coverage of all relevant aspects related to this fix.

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you change porter.yaml or a storage document record? Update the corresponding schema file.
  • If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Copy link
Member

@schristoff schristoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you and thanks for adding test cases :)

@schristoff schristoff merged commit 6c0b6ac into getporter:main Oct 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants