Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Dynamically download kubectl client #24

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

MChorfa
Copy link
Collaborator

@MChorfa MChorfa commented Oct 24, 2020

What does this change

This PR will allow Kubernetes mixin to dynamically download the kubectl client binary at runtime
if the versions don't match (controlled by a config flag)

Steps:

  • Get kubectl version from the server
  • Download kubectl according to the server version if the client version is undefined by the config flag
  • Install kubectl with the new binaries

What issue does it fix

Closes https://github.com/getporter/porter/issues/1136

If there is not an existing issue, please make sure we have context on why this change is needed. See our Contributing Guide for examples of when an existing issue isn't necessary.

Notes for the reviewer

Put any questions or notes for the reviewer here.

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

If this is your first pull request, please add your name to the bottom of our Contributors list. Thank you for making Porter better! 🙇‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Download the kubectl client binary dynamically at runtime
1 participant