Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update unit tests #221

Merged
merged 3 commits into from
Aug 7, 2023
Merged

Conversation

troy0820
Copy link
Member

@troy0820 troy0820 commented Jul 6, 2023

What does this change

Added more unit test to increase coverage around the controllers and api surface.

  • Add unit tests to controllers package

What issue does it fix

Partially closes #220
Strategy may be necessary to utilize the integration test suite to e2e the controller(s) flow

Notes for the reviewer

There is a method that is on all the reconcilers called retry which does the same thing but for different resources. Not sure if this makes sense to pull this out and move it to a different package being that it does the same thing on every reconciler but just a different object.

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you make any API changes? Update the corresponding API documentation.

@codecov
Copy link

codecov bot commented Jul 17, 2023

Codecov Report

Merging #221 (ba8c3f2) into main (26f9e86) will increase coverage by 3.39%.
The diff coverage is n/a.

❗ Current head ba8c3f2 differs from pull request most recent head 67c4d20. Consider uploading reports for the commit 67c4d20 to get more accurate results

@@            Coverage Diff             @@
##             main     #221      +/-   ##
==========================================
+ Coverage   69.35%   72.75%   +3.39%     
==========================================
  Files          13       13              
  Lines        2160     1556     -604     
==========================================
- Hits         1498     1132     -366     
+ Misses        544      291     -253     
- Partials      118      133      +15     
Flag Coverage Δ
unit-tests 72.75% <ø> (?)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 13 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@troy0820
Copy link
Member Author

troy0820 commented Aug 7, 2023

/azp run porter-integration

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@schristoff schristoff merged commit 4232163 into getporter:main Aug 7, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create test(s) that capture the lifecycle of the reconciler(s)
2 participants