Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SetControllerReference from controllerutil #258

Merged

Conversation

troy0820
Copy link
Member

This is for testing purposes

@troy0820 troy0820 force-pushed the troy0820/delete-resources-automatically branch 4 times, most recently from 2319a9d to 160ae0a Compare August 31, 2023 21:37
@schristoff
Copy link
Member

This is part of #248 that will close #54

Signed-off-by: Troy Connor <[email protected]>
@troy0820 troy0820 force-pushed the troy0820/delete-resources-automatically branch from 160ae0a to f0678bb Compare September 6, 2023 22:15
@codecov
Copy link

codecov bot commented Sep 7, 2023

Codecov Report

Merging #258 (85d24a5) into main (433e481) will decrease coverage by 4.15%.
The diff coverage is 15.38%.

@@            Coverage Diff             @@
##             main     #258      +/-   ##
==========================================
- Coverage   71.82%   67.67%   -4.15%     
==========================================
  Files          14       14              
  Lines        2165     2147      -18     
==========================================
- Hits         1555     1453     -102     
- Misses        477      547      +70     
- Partials      133      147      +14     
Flag Coverage Δ
unittests 67.67% <15.38%> (-4.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
controllers/agentaction_controller.go 80.60% <0.00%> (-1.49%) ⬇️
controllers/agentconfig_controller.go 58.78% <0.00%> (-3.63%) ⬇️
controllers/installation_controller.go 60.22% <0.00%> (-7.92%) ⬇️
controllers/credentialset_controller.go 58.04% <33.33%> (-12.18%) ⬇️
controllers/parameterset_controller.go 58.28% <33.33%> (-12.11%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@schristoff schristoff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Happy to see this

Signed-off-by: Troy Connor <[email protected]>
Signed-off-by: Troy Connor <[email protected]>
@troy0820 troy0820 merged commit df395be into getporter:main Sep 7, 2023
5 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants