Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deletion policy annotation on all installations #326

Merged
merged 1 commit into from
Jun 3, 2024

Conversation

troy0820
Copy link
Member

@troy0820 troy0820 commented May 21, 2024

What does this change

This will add the annotation that we will use to determine how we want to delete the resources (installations and otherwise) to adopt the pattern from cross-plane as noted in issue #297

This is still in draft

All this does is just add the annotation, the WIP will use this to implement the logic behind this new annotation.

What issue does it fix

Partially closes #297

Notes for the reviewer

Put any questions or notes for the reviewer here.

Checklist

  • Did you write tests?
  • Did you write documentation? maybe? public facing for sure.
  • Did you make any API changes? Update the corresponding API documentation. none

@troy0820 troy0820 force-pushed the troy0820/create-deletion-policy branch from f67ff3a to f6f2e68 Compare May 22, 2024 13:21
@troy0820 troy0820 marked this pull request as ready for review May 29, 2024 17:18
@troy0820 troy0820 force-pushed the troy0820/create-deletion-policy branch from f6f2e68 to 2ca968a Compare May 29, 2024 17:19
@troy0820 troy0820 force-pushed the troy0820/create-deletion-policy branch from 2ca968a to 6f5dde0 Compare June 3, 2024 14:32
@troy0820 troy0820 requested a review from sgettys June 3, 2024 14:56
@sgettys sgettys merged commit 4fc0ba0 into getporter:main Jun 3, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants