Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete without uninstall #331

Merged
merged 4 commits into from
Jun 25, 2024

Conversation

troy0820
Copy link
Member

@troy0820 troy0820 commented Jun 20, 2024

What does this change

This allows deletion with uninstall and deletion with "orphan" by way of deletion policy.

  • Add method for shouldOrphan
  • Add check for shouldUninstall to check the deletion policy

What issue does it fix

#297 again

Notes for the reviewer

Put any questions or notes for the reviewer here.

Checklist

  • Did you write tests?
  • Did you write documentation?
  • Did you make any API changes? Update the corresponding API documentation.

Signed-off-by: Troy Connor <[email protected]>
Signed-off-by: Troy Connor <[email protected]>
@troy0820 troy0820 changed the title Delete with uninstall Delete without uninstall Jun 24, 2024
@troy0820 troy0820 merged commit 485d89f into getporter:main Jun 25, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants