Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganize documentation #1812

Merged
merged 9 commits into from
Nov 13, 2021
Merged

Conversation

carolynvs
Copy link
Member

@carolynvs carolynvs commented Nov 1, 2021

What does this change

  • Add operator docs from the operator repo to the porter website. The magefile handles cloning the repo, or using a local copy based on the PORTER_OPERATOR_REPOSITORY environment variable.
  • Update our navigation based on our new design at https://hackmd.io/roa3Nfh4SruG0FFKyJwb7Q. This is a work in progress but all of the top level nav links are now organized according to that document. Further work is needed to edit existing pages in cases where we have combined tasked based docs with references, etc.
  • Edited some of the docs pages to work with the new navigation.
  • Updated our CSS so that the left hand nav can show 3 levels of links. Long term, we should look at how the docsy theme does navigation as what we have is difficult to work with.

Preview of operator docs at https://deploy-preview-1812--porter.netlify.app/operator/
Preview of v1 installation docs at https://deploy-preview-1812--porter.netlify.app/install/#v1-prerelease

What issue does it fix

Closes #1807
Closes #1513
Part of getporter/operator#45, additional changes to the operator repo are still required after this is merged.

Notes for the reviewer

None

Checklist

  • Unit Tests
  • Documentation
  • Schema (porter.yaml)

Signed-off-by: Carolyn Van Slyck <[email protected]>
The left nav previously was hard coded to only display 2 levels of docs.
As a short term fix to support additional levels, I've added tweaks so
that we can show links 3 deep.

Long term we should use a menu system like what the docsy theme uses for
more flexible menus.

Signed-off-by: Carolyn Van Slyck <[email protected]>
Our current structure is difficult to add new content to without
forever making the number of nav groups increase over time.

This reorganizes our navigation according to the new design which
categorizes pages by their type (concept, task, reference) and the
intended audience (end-user, admin, author, developer).

Signed-off-by: Carolyn Van Slyck <[email protected]>
Some pages had TODOs, or the pages they linked to weren't correct after
reorganizing the nav bar. I've updated pages to improve the navigation.

Signed-off-by: Carolyn Van Slyck <[email protected]>
Signed-off-by: Carolyn Van Slyck <[email protected]>
Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs carolynvs marked this pull request as ready for review November 3, 2021 15:30
@carolynvs carolynvs requested a review from iennae November 3, 2021 15:32
@iennae
Copy link
Contributor

iennae commented Nov 4, 2021

any chance of labeling the Porter Operator with some kind of "in development" label for the page? Also feels like a link to provide feedback on the operator somewhere.

* exec - run shell scripts and commands
* helm - use the helm cli
* azure - provision services on the Azure cloud
There are [many mixins](/mixins/) created both by the Porter Authors and the community.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Porter authors are part of the community. Are some mixins considered "official" Porter author maintained? or are they all community driven?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some mixins are maintained by the Porter project, i.e. they live in our github org (getporter). Others are maintained by a community member on their own and we aren't involved. I wasn't sure how to say that well.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it need to be separate? because it's possible that mixins would be adopted to the official organization?

@@ -10,6 +10,7 @@ We have a few release types available for you to use:

* [Latest](#latest)
* [Canary](#canary)
* [v1 Prerelease](#v1-prerelease)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: what if this was just prerelease, and then within the "Prelease link it talked about v1 specifically?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, thanks!

# v1 Prerelease

We would love for you to try out v1 prelease and send us any feedback that you have!
Keep in mind that the v1 prerelease is not suitable for running with production workloads, and that data migrations will not be provided or supported for v1 prerelease.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Keep in mind that prereleases are not suitable for production workloads. Data migrations will not be provided or supported for prereleases."


We would love for you to try out v1 prelease and send us any feedback that you have!
Keep in mind that the v1 prerelease is not suitable for running with production workloads, and that data migrations will not be provided or supported for v1 prerelease.
The prerelease is intended for you to try out the new features in Porter and provide feedback. It won't work with existing installations.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prereleases are intended for you to try out potential new features in Porter and provide feedback about the direction of the feature. They won't work with existing installations.

Keep in mind that the v1 prerelease is not suitable for running with production workloads, and that data migrations will not be provided or supported for v1 prerelease.
The prerelease is intended for you to try out the new features in Porter and provide feedback. It won't work with existing installations.

One way to try out Porter without messing with your current installation of Porter is to install Porter into a different PORTER_HOME directory.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can try out different versions of Porter without impacting your current version of Porter by installing to a different location via a modified PORTER_HOME environment variable.

```

Now when you want to use the v1 version of Porter, set the PORTER_HOME environment variable and add it to your PATH.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm confused by the setting of environment variables (other than for the Windows instructions). Is there a missing step or is it assumed that they are in the right directory to start with?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for calling that it, I see now that I left off how to use porter after installing, i.e. how to reset the env vars each time you want to switch to a different version of porter.

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs
Copy link
Member Author

@iennae Please take another look!

* exec - run shell scripts and commands
* helm - use the helm cli
* azure - provision services on the Azure cloud
There are [many mixins](/mixins/) created the Porter community.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh missing the by the Porter community here.

Copy link
Contributor

@iennae iennae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

overall other than the missing by LGTM

Signed-off-by: Carolyn Van Slyck <[email protected]>
@carolynvs carolynvs merged commit ca49edf into getporter:release/v1 Nov 13, 2021
@carolynvs carolynvs deleted the operator-docs branch November 13, 2021 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants