Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not check in packr files #194

Merged
merged 1 commit into from
Feb 27, 2019
Merged

Conversation

carolynvs
Copy link
Member

@carolynvs carolynvs commented Feb 27, 2019

This is part of #193 (split off from #146). Packr recommends to not check in any *-packr.go files because they are generated and needed just during the build. Either way they are causing me lots of merge conflicts to boot in my mega PR of doom. So I'm hoping we can merge this soon.

@ghost ghost assigned carolynvs Feb 27, 2019
@ghost ghost added the review label Feb 27, 2019
@carolynvs
Copy link
Member Author

Merge like it's a small change, no one is around and multiple PRs build on top of this. 😇

@carolynvs carolynvs merged commit 9eed138 into getporter:master Feb 27, 2019
@carolynvs carolynvs deleted the tidy-packr branch February 27, 2019 14:49
@ghost ghost removed the review label Feb 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants