Fix YAML parse: error converting YAML to JSON: when redis.enabled is set to false.
#176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re not allowed in this context when using redis.enabled=false.
When you set `redis.enabled` to `false` Helm cannot generate valid yaml.
The error is:
```
Error: YAML parse error on redash/templates/hook-migrations-job.yaml: error converting YAML to JSON: yaml: line 43: mapping values are not allowed in this context
helm.go:84: [debug] error converting YAML to JSON: yaml: line 43: mapping values are not allowed in this context
YAML parse error on redash/templates/hook-migrations-job.yaml
helm.sh/helm/v3/pkg/releaseutil.(*manifestFile).sort
helm.sh/helm/v3/pkg/releaseutil/manifest_sorter.go:146
helm.sh/helm/v3/pkg/releaseutil.SortManifests
helm.sh/helm/v3/pkg/releaseutil/manifest_sorter.go:106
helm.sh/helm/v3/pkg/action.(*Configuration).renderResources
helm.sh/helm/v3/pkg/action/action.go:168
helm.sh/helm/v3/pkg/action.(*Install).RunWithContext
helm.sh/helm/v3/pkg/action/install.go:312
main.runInstall
helm.sh/helm/v3/cmd/helm/install.go:314
main.newTemplateCmd.func2
helm.sh/helm/v3/cmd/helm/template.go:95
github.com/spf13/cobra.(*Command).execute
github.com/spf13/[email protected]/command.go:983
github.com/spf13/cobra.(*Command).ExecuteC
github.com/spf13/[email protected]/command.go:1115
github.com/spf13/cobra.(*Command).Execute
github.com/spf13/[email protected]/command.go:1039
main.main
helm.sh/helm/v3/cmd/helm/helm.go:83
runtime.main
runtime/proc.go:271
runtime.goexit
runtime/asm_amd64.s:1695
```
The `helm template` command generates output with wrong new-lines:
```yaml
env:
- name: REDASH_DATABASE_URL
valueFrom:
secretKeyRef:
key: connectionString
name: redash- name: REDASH_REDIS_URL
value: "redis://redis:6379/0"- name: PYTHONUNBUFFERED
value: "0"
- name: QUEUES
value: "scheduled_queries,schemas"
```
This change fixes the error.
One caveat of the fix: when `redis.enabled` is set to `true` Helm adds additional new-line:
```yaml
env:
- name: REDASH_DATABASE_URL
valueFrom:
secretKeyRef:
key: connectionString
name: redash
- name: REDASH_REDIS_PASSWORD
valueFrom:
secretKeyRef:
name: redash-redis
key: redis-password
- name: REDASH_REDIS_HOSTNAME
value: redash-redis-master
- name: REDASH_REDIS_PORT
value: "6379"
- name: REDASH_REDIS_NAME
value: "0"
## Start primary Redash configuration
```
So maybe a better fix exists.
|
I've created a PR for the same issue (& other things): #180 I would recommend to keep "my" version, because I cover both cases: postgres & redis, not just redis like here. And I don't have the "when redis.enabled is set to true, Helm adds additional new-line" issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you set
redis.enabledtofalseHelm cannot generate valid yaml. The error is:The
helm templatecommand generates output with wrong new-lines:This change fixes the error.
One caveat of the fix: when
redis.enabledis set totrueHelm adds additional new-line:So maybe a better fix exists.