Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo in total cohort size example #683

Merged
merged 1 commit into from
Oct 23, 2023
Merged

Fix typo in total cohort size example #683

merged 1 commit into from
Oct 23, 2023

Conversation

lipka
Copy link
Contributor

@lipka lipka commented Oct 22, 2023 •
edited
Loading

This PR aligns the calculation with the example in the Count Satisfying Target section.

masayuki038
masayuki038 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Collaborator

@masayuki038 masayuki038 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@justinclift
Copy link
Member

Thanks for this, merging.

Btw - ignore that restyled test failure in this case. It's not related to this PR.

(I'm personally inclined to remove that test at some point, as it's more trouble than it's worth. 😉)

@justinclift justinclift merged commit c454b52 into getredash:master Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masayuki038 masayuki038 masayuki038 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lipka @justinclift @masayuki038