Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: Actually fix the getting started #280

Merged
merged 3 commits into from
Aug 17, 2023
Merged

docs: Actually fix the getting started #280

merged 3 commits into from
Aug 17, 2023

Conversation

lynnagara
Copy link
Member

No description provided.

@lynnagara lynnagara requested a review from a team as a code owner August 16, 2023 21:44
trillville
trillville approved these changes Aug 16, 2023
View reviewed changes
Copy link

@trillville trillville left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

May want to:

  • make the docker containers for kafka/zookeeper detached or separate code blocks
  • make the topic creation separate code blocks

@lynnagara lynnagara merged commit 6286c79 into main Aug 17, 2023
8 checks passed
@lynnagara lynnagara deleted the fix-get-started branch August 17, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trillville trillville trillville approved these changes

@evanh evanh evanh approved these changes

@untitaker untitaker untitaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lynnagara @untitaker @evanh @trillville