Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(run_task_threads): Add metric to capture backpressure #300

Closed
wants to merge 1 commit into from

Conversation

nikhars
Copy link
Member

@nikhars nikhars commented Nov 6, 2023

In order to debug backpressure being raised from run task in threads, add a new metric which captures the information. This would help triage whether the kafka doomsday alert is going off because of backpressure or not.

In order to debug backpressure being raised from run task in threads,
add a new metric.
@nikhars nikhars requested a review from a team as a code owner November 6, 2023 20:49
@lynnagara
Copy link
Member

lynnagara commented Nov 6, 2023

Not sure I follow why this is needed for debugging that specific alert. Why do you want the count of message rejected (as opposed to time spent)? arroyo.processor.paused.time gives you the time the processor spends in this state, which is what we generally use instead.

@nikhars
Copy link
Member Author

nikhars commented Nov 6, 2023

Not sure I follow why this is needed for debugging that specific alert. Why do you want the count of message rejected (as opposed to time spent)? arroyo.processor.paused.time gives you the time the processor spends in this state, which is what we generally use instead.

I was emulating what the run task with multiprocessing does over here. But you are right, I can use the metric you provided to see if the consumer gets paused or not. Will close out this PR.

@nikhars nikhars closed this Nov 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants