ref: Add more metrics for slow rebalancing #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have unitless/cumulative times for all of those things, but we do not actually know how often they happen.
untitaker
changed the title
untitaker
added a commit
to getsentry/snuba
that referenced
this pull request
Dec 6, 2023
Port over the parts from getsentry/arroyo#310 that make sense -- some of the metrics I added there are duplicates and are named poorly, and I don't think we need those to line up 1:1 (also because callbacks in rust work slightly differently)
untitaker
added a commit
to getsentry/snuba
that referenced
this pull request
Dec 6, 2023
* ref(rust): Add some rebalancing-related metrics Port over the parts from getsentry/arroyo#310 that make sense -- some of the metrics I added there are duplicates and are named poorly, and I don't think we need those to line up 1:1 (also because callbacks in rust work slightly differently) * fmt
untitaker
added a commit
that referenced
this pull request
Jan 17, 2024
* ref(rust): Add some rebalancing-related metrics Port over the parts from #310 that make sense -- some of the metrics I added there are duplicates and are named poorly, and I don't think we need those to line up 1:1 (also because callbacks in rust work slightly differently) * fmt
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the unitless metrics are good because they are low overhead to measure, but in the case of rebalancing, the overhead does not matter. emit a metric value everytime partitions are assigned/revoked (and how often a callback decides to shutdown/create strategies as a result), and also emit a counter for how many partitions are being assigned