test(kafka): Add test for partial cluster failure #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For INC-599, in followup SNS-2603, add a test that ensures that the consumer reliably crashes when a broker dies. I will work a bit more on the CI setup, but basically you need to run `docker-compose up`, run that one test using `pytest tests/backends/test_kafka.py -k died -s`, and observe that it passes. This is a problem though because it means we cannot reproduce the failure we have seen in that incident, where the consumer hangs after broker failure.
fpacifici
reviewed
Jan 19, 2024
|
this didn't end up going anywhere, closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For INC-599, in followup SNS-2603, add a test that ensures that the
consumer reliably crashes when a broker dies. I will work a bit more on
the CI setup, but basically you need to run
docker-compose up, runthat one test using
pytest tests/backends/test_kafka.py -k died -s,and observe that it passes.
This is a problem though because it means we cannot reproduce the
failure we have seen in that incident, where the consumer hangs after
broker failure.