ref: Use coarsetime consistently #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
untitaker
added a commit
to getsentry/snuba
that referenced
this pull request
May 17, 2024
Changes necessary for getsentry/arroyo#366, and additional timers for get_str_config, since that one acquires multiple global locks and might impact concurrency.
coarsetime is a crate that allows you to fetch the current time with an in-memory cache. This tends to be faster than actually getting the current time. Previously we were using Instant::now_without_update, which does not actually give us any perf benefits. Let's use ::recent everywhere and update the timestamp in the StreamProcessor.
|
quanta is another alternative, but I can't tell you which is better. |
loewenheim
approved these changes
May 17, 2024
I found that all timing-related things are now gone from profiles, so I think it's good enough. quanta looks like it has a quite large deptree |
untitaker
added a commit
to getsentry/snuba
that referenced
this pull request
May 17, 2024
* ref: Upgrade arroyo, use coarsetime Changes necessary for getsentry/arroyo#366, and additional timers for get_str_config, since that one acquires multiple global locks and might impact concurrency. * bump arroyo * update arroyo again * remove another close * fix tests again
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
coarsetime is a crate that allows you to fetch the current time with an
in-memory cache. This tends to be faster than actually getting the
current time.
Previously we were using Instant::now_without_update, which does not
actually give us any perf benefits. Let's use ::recent everywhere and
update the timestamp in the StreamProcessor.