Ref: Github Action for updating Sentry dependencies. #512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scripts/update-javascript.sh
Outdated
|
|
||
| tagPrefix='' | ||
| repo="https://github.com/getsentry/sentry-javascript.git" | ||
| packages=('@sentry/browser' '@sentry/core' '@sentry/integrations' '@sentry/react' '@sentry/vue' '@sentry/angular' '@sentry/angular-ivy' '@sentry/types' '@sentry/utils') |
There was a problem hiding this comment.
I believe this won't work for @sentry/angular-ivy, @sentry/angular, @sentry/react, and @sentry/vue. As the update-package-json.sh runs yarn upgrade.
I tried to run yarn upgrade and it added these as deps not upgrading the peers.
There was a problem hiding this comment.
nice catch!, sucks that yarn upgrade doesn't support peerDependencies...
I added another way of updating the peerDependencies by using the add command with the --peer flag instead of relying on the upgrade command
…into feat/auto-bump=dep
…ed current branch for testing
|
The PR will not pass for the time being because the update logic compares with the main branch and this branch isn't the main branch, but all the previous steps are passing |
lucas-zimerman
commented
Dec 21, 2023
kahest
approved these changes
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #510
#skip-changelog