ref: convert last sprintf call to snprintf #3077
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Follows #2866 to convert potentially unsafe usage of
sprintf
tosnprintf
. See #2785.💡 Motivation and Context
This also causes Xcode 13+ builds to break when using address sanitizer after making the changes in #3075
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
- [ ] I added tests to verify the changes.The tests required for this would require extensive effort disproportionate to the simplicity of the change.sendDefaultPII
is enabled.- [ ] I updated the docs if needed.- [ ] Review from the native team if needed.🔮 Next steps