Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Remove unused SentryCrashCString #4045

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Jun 10, 2024

📜 Description

Remove unused SentryCrashCString including unused logic in the SentryCrashInstallation.

#skip-changelog

💡 Motivation and Context

Came up in #2785 (comment).

💚 How did you test it?

Unit tests and manually crashing the app in the sample app.

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Remove unused SentryCrashCString including unused logic in the
SentryCrashInstallation.
Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always good to see a lot of code going away.

Copy link

codecov bot commented Jun 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.172%. Comparing base (0589699) to head (0af4d7d).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4045       +/-   ##
=============================================
+ Coverage   91.093%   91.172%   +0.078%     
=============================================
  Files          608       607        -1     
  Lines        47540     47554       +14     
  Branches     17049     17080       +31     
=============================================
+ Hits         43306     43356       +50     
+ Misses        4164      4018      -146     
- Partials        70       180      +110     
Files Coverage Δ
...entryCrash/Installations/SentryCrashInstallation.m 44.827% <ø> (+10.617%) ⬆️

... and 34 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0589699...0af4d7d. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1227.02 ms 1247.46 ms 20.44 ms
Size 21.58 KiB 654.59 KiB 633.01 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
2affdbd 1224.29 ms 1248.06 ms 23.77 ms
5e66a38 1224.16 ms 1237.76 ms 13.60 ms
f801098 1225.41 ms 1237.45 ms 12.04 ms
ff09c7e 1244.86 ms 1246.68 ms 1.82 ms
f938d24 1223.26 ms 1242.12 ms 18.86 ms
1a4da1b 1222.14 ms 1239.50 ms 17.36 ms
8e4bc70 1229.18 ms 1240.86 ms 11.67 ms
324dc7b 1210.33 ms 1244.92 ms 34.59 ms
11b2ffa 1204.86 ms 1218.16 ms 13.31 ms
c00eafe 1253.04 ms 1256.41 ms 3.37 ms

App size

Revision Plain With Sentry Diff
2affdbd 22.85 KiB 411.37 KiB 388.52 KiB
5e66a38 22.85 KiB 408.88 KiB 386.03 KiB
f801098 21.58 KiB 614.71 KiB 593.13 KiB
ff09c7e 20.76 KiB 427.77 KiB 407.00 KiB
f938d24 20.76 KiB 434.88 KiB 414.12 KiB
1a4da1b 21.58 KiB 418.33 KiB 396.75 KiB
8e4bc70 21.58 KiB 625.90 KiB 604.32 KiB
324dc7b 22.85 KiB 408.84 KiB 385.99 KiB
11b2ffa 22.85 KiB 412.67 KiB 389.82 KiB
c00eafe 20.76 KiB 432.88 KiB 412.12 KiB

@philipphofmann philipphofmann merged commit 3478fc5 into main Jun 10, 2024
68 of 71 checks passed
@philipphofmann philipphofmann deleted the ref/remove-sentry-crash-c-string branch June 10, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants