Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref: Remove unused tracer arg for TracerDelegate #4352

Merged
merged 2 commits into from
Sep 20, 2024

Conversation

philipphofmann
Copy link
Member

Remove passing tracer to the tracer delegate activeSpan because it's not used.

#skip-changelog

Remove passing tracer to the tracer delegate activeSpan because it's
not used.
Copy link

github-actions bot commented Sep 19, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1221.51 ms 1239.51 ms 18.00 ms
Size 21.58 KiB 714.18 KiB 692.60 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d760c3f 1228.58 ms 1246.22 ms 17.64 ms
676fe22 1220.71 ms 1240.14 ms 19.43 ms
01a28a9 1237.24 ms 1253.24 ms 16.00 ms
cf724da 1243.14 ms 1261.44 ms 18.30 ms
0ecf042 1228.25 ms 1250.67 ms 22.42 ms
d9308fd 1214.89 ms 1244.37 ms 29.47 ms
07b120c 1225.53 ms 1247.20 ms 21.67 ms
1c96132 1229.29 ms 1248.14 ms 18.86 ms
bd2afa6 1245.24 ms 1263.18 ms 17.94 ms
533859f 1237.78 ms 1249.76 ms 11.98 ms

App size

Revision Plain With Sentry Diff
d760c3f 22.84 KiB 403.17 KiB 380.33 KiB
676fe22 21.58 KiB 698.12 KiB 676.54 KiB
01a28a9 22.85 KiB 405.39 KiB 382.54 KiB
cf724da 20.76 KiB 430.52 KiB 409.76 KiB
0ecf042 21.58 KiB 631.82 KiB 610.24 KiB
d9308fd 21.58 KiB 612.82 KiB 591.24 KiB
07b120c 21.58 KiB 614.90 KiB 593.32 KiB
1c96132 21.58 KiB 418.51 KiB 396.93 KiB
bd2afa6 20.76 KiB 420.55 KiB 399.79 KiB
533859f 22.85 KiB 408.84 KiB 386.00 KiB

Previous results on branch: ref/remove-not-needed-tracer-arg

Startup times

Revision Plain With Sentry Diff
d1410ba 1246.27 ms 1266.00 ms 19.73 ms

App size

Revision Plain With Sentry Diff
d1410ba 21.58 KiB 714.18 KiB 692.60 KiB

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.658%. Comparing base (394ad33) to head (c70e6ff).
Report is 2 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4352       +/-   ##
=============================================
- Coverage   91.687%   91.658%   -0.030%     
=============================================
  Files          621       622        +1     
  Lines        50441     50528       +87     
  Branches     18177     18279      +102     
=============================================
+ Hits         46248     46313       +65     
- Misses        4100      4122       +22     
  Partials        93        93               
Files with missing lines Coverage Δ
Sources/Sentry/SentryPerformanceTracker.m 100.000% <ø> (ø)
Sources/Sentry/SentryTracer.m 96.728% <100.000%> (ø)
...ts/SentryTests/Transaction/SentryTracerTests.swift 98.370% <100.000%> (ø)

... and 23 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 394ad33...c70e6ff. Read the comment docs.

@philipphofmann philipphofmann merged commit 5783680 into main Sep 20, 2024
62 of 65 checks passed
@philipphofmann philipphofmann deleted the ref/remove-not-needed-tracer-arg branch September 20, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants