Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Remove benchmarking schedule #4378

Merged
merged 1 commit into from
Sep 30, 2024
Merged

Conversation

philipphofmann
Copy link
Member

Remove running the benchmarks at midnight because nobody looks at the data.

#skip-changelog

Remove running the benchmarks at midnight, because nobody takes a look
at the data.
Copy link

github-actions bot commented Sep 30, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1237.65 ms 1256.88 ms 19.23 ms
Size 21.58 KiB 736.50 KiB 714.92 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
d3630c3 1229.78 ms 1241.94 ms 12.16 ms
9fa25c2 1211.88 ms 1228.36 ms 16.48 ms
e71cf92 1201.69 ms 1226.52 ms 24.83 ms
b2f82fa 1237.78 ms 1256.02 ms 18.24 ms
84fdd22 1229.73 ms 1243.43 ms 13.69 ms
9cc7e7c 1231.84 ms 1245.24 ms 13.41 ms
6001822 1234.49 ms 1265.20 ms 30.71 ms
e19cca3 1211.69 ms 1231.04 ms 19.35 ms
804fd04 1224.46 ms 1243.77 ms 19.31 ms
60d6cec 1257.14 ms 1273.92 ms 16.78 ms

App size

Revision Plain With Sentry Diff
d3630c3 22.84 KiB 403.19 KiB 380.34 KiB
9fa25c2 22.85 KiB 407.44 KiB 384.59 KiB
e71cf92 20.76 KiB 419.85 KiB 399.10 KiB
b2f82fa 20.76 KiB 419.62 KiB 398.86 KiB
84fdd22 21.58 KiB 683.50 KiB 661.92 KiB
9cc7e7c 22.84 KiB 403.14 KiB 380.29 KiB
6001822 22.85 KiB 410.98 KiB 388.13 KiB
e19cca3 21.58 KiB 669.74 KiB 648.16 KiB
804fd04 21.58 KiB 695.04 KiB 673.46 KiB
60d6cec 22.84 KiB 403.51 KiB 380.67 KiB

@philipphofmann
Copy link
Member Author

@armcknight, if you disagree, we can always revert the PR.

@brustolin
Copy link
Contributor

Why did you closed this @philipphofmann ?

@philipphofmann
Copy link
Member Author

Ups wanted to merge instead. Sorry.

@philipphofmann philipphofmann merged commit f3c0746 into main Sep 30, 2024
16 of 18 checks passed
@philipphofmann philipphofmann deleted the ci/remove-benchmark-schedule branch September 30, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants