Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: AppHangsV2 #4379

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: AppHangsV2 #4379

wants to merge 6 commits into from

Conversation

philipphofmann
Copy link
Member

@philipphofmann philipphofmann commented Sep 30, 2024

📜 Description

Expose the AppHangsV2 algorithm with the options
enableAppHangTrackingV2 and
enableReportNonFullyBlockingAppHangs.

Docs PR: getsentry/sentry-docs#11458.

💡 Motivation and Context

Fixes GH-3492

💚 How did you test it?

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Expose the AppHangsV2 algorithm with the options
enableAppHangTrackingV2 and
enableReportNonFullyBlockingAppHangs.

Fixes GH-3492
Copy link

github-actions bot commented Sep 30, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 77a883a

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

Attention: Patch coverage is 94.59459% with 8 lines in your changes missing coverage. Please review.

Project coverage is 91.490%. Comparing base (4eea4d1) to head (77a883a).

Files with missing lines Patch % Lines
...ations/ANR/SentryANRTrackingIntegrationTests.swift 88.888% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4379       +/-   ##
=============================================
+ Coverage   91.424%   91.490%   +0.065%     
=============================================
  Files          628       630        +2     
  Lines        50530     50732      +202     
  Branches     18255     18412      +157     
=============================================
+ Hits         46197     46415      +218     
+ Misses        4240      4224       -16     
  Partials        93        93               
Files with missing lines Coverage Δ
Sources/Sentry/SentryANRTrackingIntegration.m 100.000% <100.000%> (ø)
Sources/Sentry/SentryBaseIntegration.m 96.969% <100.000%> (+5.541%) ⬆️
Sources/Sentry/SentryDependencyContainer.m 96.250% <100.000%> (+7.009%) ⬆️
Sources/Sentry/SentryEvent.m 98.924% <100.000%> (+0.011%) ⬆️
Sources/Sentry/SentryOptions.m 99.270% <100.000%> (+0.005%) ⬆️
...try/SentryWatchdogTerminationTrackingIntegration.m 93.750% <100.000%> (+0.132%) ⬆️
Sources/Swift/Integrations/ANR/SentryANRType.swift 100.000% <100.000%> (ø)
...yTests/Helper/SentryDependencyContainerTests.swift 100.000% <100.000%> (ø)
Tests/SentryTests/SentryOptionsTest.m 97.905% <100.000%> (+0.002%) ⬆️
...ations/ANR/SentryANRTrackingIntegrationTests.swift 93.236% <88.888%> (-2.384%) ⬇️

... and 15 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eea4d1...77a883a. Read the comment docs.

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good, but CI is not happy

@philipphofmann
Copy link
Member Author

@brustolin, CI is happy now, except for benchmarks, but that's Saucelabs. Please have another look.

Copy link
Contributor

@brustolin brustolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add the option to ignore non fully blocking app hangs
2 participants