-
-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: AppHangsV2 #4379
base: main
Are you sure you want to change the base?
feat: AppHangsV2 #4379
Conversation
Expose the AppHangsV2 algorithm with the options enableAppHangTrackingV2 and enableReportNonFullyBlockingAppHangs. Fixes GH-3492
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4379 +/- ##
=============================================
+ Coverage 91.424% 91.490% +0.065%
=============================================
Files 628 630 +2
Lines 50530 50732 +202
Branches 18255 18412 +157
=============================================
+ Hits 46197 46415 +218
+ Misses 4240 4224 -16
Partials 93 93
... and 15 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks good, but CI is not happy
@brustolin, CI is happy now, except for benchmarks, but that's Saucelabs. Please have another look. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
📜 Description
Expose the AppHangsV2 algorithm with the options
enableAppHangTrackingV2 and
enableReportNonFullyBlockingAppHangs.
Docs PR: getsentry/sentry-docs#11458.
💡 Motivation and Context
Fixes GH-3492
💚 How did you test it?
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps