fix: Linking ongoing trace to crash event

[philipphofmann]

📜 Description

Fix linking a crash event to an ongoing trace by skipping setting the trace context in Scope.applyToEvent for crash events.

💡 Motivation and Context

Fixes GH-4375

💚 How did you test it?

I could reproduce the problem in the SwiftUI sample app with the following code in the SwiftUIApp.swift file:

init() {
    SentrySDK.start { options in
        options.dsn = "https://[email protected]/5428557"
        options.debug = true
        options.tracesSampleRate = 1.0
        options.enableAutoPerformanceTracing = false
        options.initialScope = { scope in
            let user = User()
            user.email = "[email protected]"
            scope.setUser(user)
            return scope
        }
    }
    
    let t = SentrySDK.startTransaction(name: "after-crash", operation: "crash", bindToScope: true)
    let child = t.startChild(operation: "hello")

    DispatchQueue.global().asyncAfter(deadline: .now() + 1.0) {
        child.finish()
        t.finish()
    }
}

Event in Sentry before the fix:

Event in Sentry after the fix:

📝 Checklist

You have to check all boxes before merging:

• I reviewed the submitted code.
• I added tests to verify the changes.
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
• I updated the docs if needed.
• Review from the native team if needed.
• No breaking change or entry added to the changelog.
• No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.447%. Comparing base (4eea4d1) to head (b8f816e).
Report is 1 commits behind head on main.

Additional details and impacted files

@@              Coverage Diff              @@
##              main     #4393       +/-   ##
=============================================
+ Coverage   91.424%   91.447%   +0.022%     
=============================================
  Files          628       629        +1     
  Lines        50530     50630      +100     
  Branches     18255     18343       +88     
=============================================
+ Hits         46197     46300      +103     
+ Misses        4240      4237        -3     
  Partials        93        93               

Files with missing lines	Coverage Δ
Sources/Sentry/SentryScope.m	96.734% <100.000%> (+0.040%)	⬆️
Tests/SentryTests/SentryScopeSwiftTests.swift	98.971% <100.000%> (+0.017%)	⬆️

... and 15 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4eea4d1...b8f816e. Read the comment docs.

[brustolin]

LGTM