Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add getDebugImagesForImageAddressesFromCache method in the HybridSDKs header #4460

Merged

Conversation

antonis
Copy link
Collaborator

@antonis antonis commented Oct 21, 2024

📜 Description

Add getDebugImagesForImageAddressesFromCache method in the HybridSDKs header.

💡 Motivation and Context

See discussion in getsentry/sentry-react-native#4169 (comment)

💚 How did you test it?

CI

📝 Checklist

You have to check all boxes before merging:

  • I reviewed the submitted code.
  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

#skip-changelog

Copy link

codecov bot commented Oct 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.806%. Comparing base (fc350a4) to head (949f040).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4460       +/-   ##
=============================================
- Coverage   91.817%   91.806%   -0.011%     
=============================================
  Files          610       610               
  Lines        68193     68226       +33     
  Branches     24478     24491       +13     
=============================================
+ Hits         62613     62636       +23     
- Misses        5487      5498       +11     
+ Partials        93        92        -1     
Files with missing lines Coverage Δ
...ts/SentryCrash/SentryDebugImageProviderTests.swift 100.000% <100.000%> (ø)

... and 8 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc350a4...949f040. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1226.21 ms 1236.50 ms 10.29 ms
Size 21.90 KiB 708.34 KiB 686.44 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
eef4553 1248.12 ms 1252.37 ms 4.24 ms
7192d9e 1221.86 ms 1248.28 ms 26.42 ms
42ef6ba 1234.35 ms 1252.29 ms 17.94 ms
bd05478 1233.82 ms 1255.56 ms 21.74 ms
2deb275 1215.63 ms 1232.45 ms 16.82 ms
83887af 1196.94 ms 1206.82 ms 9.88 ms
b16d18c 1245.60 ms 1250.94 ms 5.34 ms
c471221 1244.57 ms 1257.94 ms 13.37 ms
52e4912 1216.25 ms 1226.69 ms 10.44 ms
9fef8d1 1236.57 ms 1255.26 ms 18.68 ms

App size

Revision Plain With Sentry Diff
eef4553 21.58 KiB 418.00 KiB 396.42 KiB
7192d9e 20.76 KiB 431.71 KiB 410.95 KiB
42ef6ba 21.58 KiB 417.86 KiB 396.28 KiB
bd05478 20.76 KiB 432.33 KiB 411.57 KiB
2deb275 21.58 KiB 681.72 KiB 660.14 KiB
83887af 21.58 KiB 419.64 KiB 398.06 KiB
b16d18c 20.76 KiB 437.12 KiB 416.36 KiB
c471221 22.85 KiB 413.89 KiB 391.04 KiB
52e4912 21.58 KiB 418.14 KiB 396.56 KiB
9fef8d1 21.58 KiB 650.82 KiB 629.24 KiB

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM

@antonis antonis merged commit 6230686 into main Oct 21, 2024
66 of 67 checks passed
@antonis antonis deleted the antonis/hybridsdks-getDebugImagesForImageAddressesFromCache branch October 21, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants