ref(transport): Log a warning when dropping envelopes due to rate-limiting

[rwachtler]

📜 Description

• Raise the level of an existing log statement which indicated that all envelope items were rate-limited, to SENTRY_LOG_WARN.
• Introduce a new log statement which will log a warning each time an envelope item has been dropped due to an exceeding rate-limit.
• Update clang-formatter to 19.1.2 (will be addressed in a separate PR)
  • When trying to commit I've got following error:
    • clang-format version mismatch, expected: 19.1.1, but found: 19.1.2. Please run make init to update your local dev tools. This may actually upgrade to a newer version than what is currently recorded in the lockfile; if that happens, please commit the update to the lockfile as well.
    • Tried to resolve via make init, but then followed This may actually upgrade to a newer version than what is currently recorded in the lockfile; if that happens, please commit the update to the lockfile as well.
  • It looks like pre-commit, python and mobile-dev-inc/tap/maestro got updated as well, but since those weren't crucial for the commit, I didn't stage/commit those changes.

💡 Motivation and Context

• Fixes Change rate limiting logs to level warning or error #4456

💚 How did you test it?

• Ran SentryHttpTransportTests

See below:

Running all tests in SentryHttpTransportTests

📝 Checklist

You have to check all boxes before merging:

• I reviewed the submitted code.
• I added tests to verify the changes.
• No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
• I updated the docs if needed.
• Review from the native team if needed.
• No breaking change or entry added to the changelog.
• No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

• Let me know if the new log message is specific/descriptive enough, or feel free to suggest an alternative. Thanks!

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.810%. Comparing base (fc350a4) to head (6c3e79b).
Report is 5 commits behind head on main.

Additional details and impacted files

@@              Coverage Diff              @@
##              main     #4463       +/-   ##
=============================================
- Coverage   91.817%   91.810%   -0.008%     
=============================================
  Files          610       610               
  Lines        68193     68231       +38     
  Branches     24478     24497       +19     
=============================================
+ Hits         62613     62643       +30     
- Misses        5487      5496        +9     
+ Partials        93        92        -1     

Files with missing lines	Coverage Δ
Sources/Sentry/SentryHttpTransport.m	98.069% <100.000%> (+0.007%)	⬆️

... and 9 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc350a4...6c3e79b. Read the comment docs.

[brustolin]

LGTM

[philipphofmann]

Thanks, the warning log message will be lost in all the noise, but we will fix that here #4467.

[philipphofmann]

This PR deserves an entry into the Changelog. I think it's an improvement. So add an ##Unreleased entry with a ### Improvements section to the changelog and mention this PR.

[rwachtler]

This PR deserves an entry into the Changelog. I think it's an improvement. So add an ##Unreleased entry with a ### Improvements section to the changelog and mention this PR.

@philipphofmann Done, I've also removed the #skip-changelog from the description.

A general question from my side - not every single commit on a branch has to follow the rules defined here, right? So as long as let's say the commit message of the final "Squash & Merge" does follow the rules, I'm good?

[brustolin]

A general question from my side - not every single commit on a branch has to follow the rules defined here, right? So as long as let's say the commit message of the final "Squash & Merge" does follow the rules, I'm good?

Yes, only the "Squash & merge" message needs to follow the rules.

[philipphofmann]

LGTM