Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(feedback): fix static pod lint #4658

Conversation

armcknight
Copy link
Member

trying to fix the last build issue in #4652; #skip-changelog; for #4272

Copy link

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against 463468d

@armcknight armcknight marked this pull request as draft December 21, 2024 01:54
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

Attention: Patch coverage is 83.01887% with 9 lines in your changes missing coverage. Please review.

Project coverage is 90.553%. Comparing base (e79c9fa) to head (463468d).

Files with missing lines Patch % Lines
...grations/UserFeedback/SentryUserFeedbackForm.swift 0.000% 6 Missing ⚠️
Sources/Sentry/SentryFeedback.m 93.333% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@                                Coverage Diff                                 @@
##           armcknight/feat(feedback)/validate-envelopes     #4658       +/-   ##
==================================================================================
- Coverage                                        90.594%   90.553%   -0.042%     
==================================================================================
  Files                                               623       623               
  Lines                                             71226     71231        +5     
  Branches                                          25995     25355      -640     
==================================================================================
- Hits                                              64527     64502       -25     
- Misses                                             6601      6636       +35     
+ Partials                                             98        93        -5     
Files with missing lines Coverage Δ
...ts/Integrations/Feedback/SentryFeedbackTests.swift 100.000% <100.000%> (ø)
Sources/Sentry/SentryFeedback.m 93.333% <93.333%> (ø)
...grations/UserFeedback/SentryUserFeedbackForm.swift 0.000% <0.000%> (ø)

... and 20 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e79c9fa...463468d. Read the comment docs.

Copy link

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1233.92 ms 1255.27 ms 21.35 ms
Size 22.32 KiB 763.29 KiB 740.98 KiB

Baseline results on branch: armcknight/feat(feedback)/validate-envelopes

Startup times

Revision Plain With Sentry Diff
7c33e26 1231.92 ms 1253.49 ms 21.57 ms

App size

Revision Plain With Sentry Diff
7c33e26 22.32 KiB 765.13 KiB 742.82 KiB

@armcknight
Copy link
Member Author

looks like the correct solution is #4659

@armcknight armcknight closed this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant