-
-
Notifications
You must be signed in to change notification settings - Fork 333
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat: Add native SDK information in the replay option event #4663
Open
brustolin
wants to merge
12
commits into
main
Choose a base branch
from
feat/sdk-info-sr-tags
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+75
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brustolin
requested review from
philipphofmann,
armcknight and
philprime
as code owners
December 23, 2024 15:01
|
brustolin
commented
Dec 23, 2024
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5e579af | 1239.16 ms | 1248.49 ms | 9.33 ms |
5e66a38 | 1209.10 ms | 1233.90 ms | 24.79 ms |
3277f18 | 1229.29 ms | 1248.92 ms | 19.63 ms |
3cba0e8 | 1250.86 ms | 1258.39 ms | 7.53 ms |
7fe37ab | 1228.92 ms | 1243.86 ms | 14.94 ms |
0ecf042 | 1228.25 ms | 1250.67 ms | 22.42 ms |
0970e44 | 1237.32 ms | 1251.53 ms | 14.21 ms |
e773cad | 1221.82 ms | 1240.55 ms | 18.73 ms |
f4a6925 | 1237.29 ms | 1249.35 ms | 12.07 ms |
216bdf9 | 1193.69 ms | 1217.90 ms | 24.21 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
5e579af | 21.58 KiB | 656.60 KiB | 635.01 KiB |
5e66a38 | 22.85 KiB | 408.88 KiB | 386.03 KiB |
3277f18 | 22.84 KiB | 402.88 KiB | 380.03 KiB |
3cba0e8 | 22.84 KiB | 403.19 KiB | 380.34 KiB |
7fe37ab | 21.58 KiB | 542.28 KiB | 520.70 KiB |
0ecf042 | 21.58 KiB | 631.82 KiB | 610.24 KiB |
0970e44 | 22.32 KiB | 761.50 KiB | 739.18 KiB |
e773cad | 21.58 KiB | 681.75 KiB | 660.17 KiB |
f4a6925 | 21.58 KiB | 706.47 KiB | 684.89 KiB |
216bdf9 | 21.58 KiB | 418.13 KiB | 396.54 KiB |
…sentry-cocoa into feat/sdk-info-sr-tags
brustolin
commented
Dec 24, 2024
brustolin
commented
Dec 24, 2024
brustolin
commented
Dec 24, 2024
Sources/Sentry/include/SentrySessionReplayIntegration+Private.h
Outdated
Show resolved
Hide resolved
brustolin
commented
Dec 24, 2024
Sources/Sentry/include/SentrySessionReplayIntegration+Private.h
Outdated
Show resolved
Hide resolved
brustolin
commented
Dec 24, 2024
Sources/Sentry/include/SentrySessionReplayIntegration+Private.h
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4663 +/- ##
=============================================
+ Coverage 90.649% 90.670% +0.020%
=============================================
Files 620 621 +1
Lines 71021 71190 +169
Branches 25819 25942 +123
=============================================
+ Hits 64380 64548 +168
+ Misses 6545 6544 -1
- Partials 96 98 +2
... and 25 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Added cocoa name and version in the session replay options event for easy investigation.
💚 How did you test it?
Unit test
📝 Checklist
You have to check all boxes before merging:
sendDefaultPII
is enabled.🔮 Next steps