Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Add native SDK information in the replay option event #4663

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

brustolin
Copy link
Contributor

@brustolin brustolin commented Dec 23, 2024

📜 Description

Added cocoa name and version in the session replay options event for easy investigation.

image

💚 How did you test it?

Unit test

📝 Checklist

You have to check all boxes before merging:

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link

github-actions bot commented Dec 23, 2024

Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Generated by 🚫 dangerJS against c87f10b

CHANGELOG.md Outdated Show resolved Hide resolved
@brustolin brustolin mentioned this pull request Dec 23, 2024
7 tasks
Copy link

github-actions bot commented Dec 23, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 1227.61 ms 1252.87 ms 25.26 ms
Size 22.32 KiB 762.11 KiB 739.79 KiB

Baseline results on branch: main

Startup times

Revision Plain With Sentry Diff
5e579af 1239.16 ms 1248.49 ms 9.33 ms
5e66a38 1209.10 ms 1233.90 ms 24.79 ms
3277f18 1229.29 ms 1248.92 ms 19.63 ms
3cba0e8 1250.86 ms 1258.39 ms 7.53 ms
7fe37ab 1228.92 ms 1243.86 ms 14.94 ms
0ecf042 1228.25 ms 1250.67 ms 22.42 ms
0970e44 1237.32 ms 1251.53 ms 14.21 ms
e773cad 1221.82 ms 1240.55 ms 18.73 ms
f4a6925 1237.29 ms 1249.35 ms 12.07 ms
216bdf9 1193.69 ms 1217.90 ms 24.21 ms

App size

Revision Plain With Sentry Diff
5e579af 21.58 KiB 656.60 KiB 635.01 KiB
5e66a38 22.85 KiB 408.88 KiB 386.03 KiB
3277f18 22.84 KiB 402.88 KiB 380.03 KiB
3cba0e8 22.84 KiB 403.19 KiB 380.34 KiB
7fe37ab 21.58 KiB 542.28 KiB 520.70 KiB
0ecf042 21.58 KiB 631.82 KiB 610.24 KiB
0970e44 22.32 KiB 761.50 KiB 739.18 KiB
e773cad 21.58 KiB 681.75 KiB 660.17 KiB
f4a6925 21.58 KiB 706.47 KiB 684.89 KiB
216bdf9 21.58 KiB 418.13 KiB 396.54 KiB

Previous results on branch: feat/sdk-info-sr-tags

Startup times

Revision Plain With Sentry Diff
7cdca55 1240.24 ms 1256.24 ms 16.00 ms
b7ac501 1230.59 ms 1253.66 ms 23.07 ms

App size

Revision Plain With Sentry Diff
7cdca55 22.32 KiB 761.54 KiB 739.22 KiB
b7ac501 22.32 KiB 761.95 KiB 739.63 KiB

@brustolin brustolin marked this pull request as draft December 23, 2024 16:23
@brustolin brustolin marked this pull request as ready for review December 24, 2024 08:44
Copy link

codecov bot commented Dec 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.670%. Comparing base (52523e7) to head (c87f10b).

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##              main     #4663       +/-   ##
=============================================
+ Coverage   90.649%   90.670%   +0.020%     
=============================================
  Files          620       621        +1     
  Lines        71021     71190      +169     
  Branches     25819     25942      +123     
=============================================
+ Hits         64380     64548      +168     
+ Misses        6545      6544        -1     
- Partials        96        98        +2     
Files with missing lines Coverage Δ
Sources/Sentry/SentryMeta.m 72.727% <100.000%> (+22.727%) ⬆️
.../SessionReplay/RRWeb/SentryRRWebOptionsEvent.swift 100.000% <100.000%> (ø)
...tegrations/SessionReplay/SentryReplayOptions.swift 95.000% <100.000%> (+0.084%) ⬆️
...tegrations/SessionReplay/SentrySessionReplay.swift 97.619% <100.000%> (+0.009%) ⬆️
...tions/SessionReplay/SentrySessionReplayTests.swift 99.111% <100.000%> (+0.041%) ⬆️

... and 25 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52523e7...c87f10b. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants