-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(flags): document python FeatureFlagsIntegration for custom flag tracking #12152
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 204 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
|
||
## Install | ||
|
||
Install `sentry-sdk` (>=TODO:) from PyPI. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TODO after release!
|
||
```python | ||
import sentry_sdk | ||
from sentry_sdk.integrations.featureflags import FeatureFlagsIntegration |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The module's name need to be feature_flags
. Spaces are rendered as underscores in Python module names. This needs to be fixed within the SDK code. You can keep the featureflags
module for backwards compatibility reasons but we shouldn't document it. We probably don't need the backwards compatibility any way as I doubt anyone's using it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spaces are rendered as underscores in Python module names. This needs to be fixed within the SDK code.
What code are you referring to? Where do we have "feature flags"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updating in getsentry/sentry-python#3902
Including this in another PR: https://github.com/getsentry/sentry-docs/pull/12203/files#r1904618798 |
Do not merge until getsentry/sentry-python#3860 is released. This doc follows the structure of python/integrations/launchdarkly/ and openfeature/