Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(flags): re-publish docs on python unleash and generic integrations #12300

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

aliu39
Copy link
Member

@aliu39 aliu39 commented Jan 10, 2025

These docs were originally approved and published, but reverted in #12296 since the integrations aren't released, and won't be for at least a couple days.

This PR re-publishes them and fixes some sample code + versioning (see latest commit). Don't merge until sentry-python rolls a release

Copy link

vercel bot commented Jan 10, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 10, 2025 0:50am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 0:50am
develop-docs ⬜️ Ignored (Inspect) Visit Preview Jan 10, 2025 0:50am

Copy link

codecov bot commented Jan 10, 2025

Bundle Report

Changes will increase total bundle size by 435 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 10.37MB 441 bytes (0.0%) ⬆️
sentry-docs-client-array-push 9.3MB 6 bytes (-0.0%) ⬇️

@@ -0,0 +1,49 @@
---
title: Generic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we make the title a little more descriptive here? Like 'Generic Feature Flags' or something like that? Same with the page title for 'Unleash', maybe 'Feature Flags using Unleash'?

Copy link
Contributor

@coolguyzone coolguyzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants