-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: send content feedback plausible events #12400
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Bundle ReportChanges will increase total bundle size by 21.24kB (0.11%) ⬆️. This is within the configured threshold ✅ Detailed changes
View changes by path for bundle: sentry-docs-server-cjs
|
Should we maybe move this somewhere into the "Help improve this content" section below the navigation buttons? |
I thought about it, but I think it's more useful to be immediately next to the content, also it's very compact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally looks good to me, left some comments!
I'll also need to set up the custom plausible event before merging this.
Let's also get feedback from @stephanie-anderson on this one
General feedback from the preview so far: User FeedbackWe should definitely provide feedback on each interactive element, as soon as users interact with it. So for example, when someone presses "Yes" or "No", we should let the user know that the system actually did something (which is currently not the case for "Yes"). There are other examples out there that work like this preview (stripe, mintlify), but they too are lacking a feedback component. PlacingWe should think about the proper placing of this element again. Was this a conscious decision to put it above the page navigation buttons on the bottom? I'm torn, but I do like how Next.js is handling it. What I like about it is that this visual element is easily distinguishable from the rest, it's subtle but still eye-catching. And bonus: it offers a range of options. Getting Feedback for "Yes" as wellAgain something that is really nice about the Next.js docs, they always ask for feedback, regardless of the user's selection. What I also like about it is the subtlety of the textarea. It's not a modal, it's tiny. I think this could positively influence how willingly users are to providing a feedback message. Modal feels like a form they have to fill out. This little box though seems "manageable" and doesn't interrupt the users flow (of setting up Sentry for their app) so much. The form is only submittable onceWe should make that visible to the user, by no longer showing the voting options. Instead we could let the users know that their feedback has been submitted, and remove the buttons. StylesIf we stick with the modal, we need to address the contrast issues for the primary button: Text-heavinessWe need to shorten the wording on the modal (if it stays). "Help us improve", "What could we improve" etc is redundant, we should try to make it as sharp and short as possible. Same goes for the confirmation step of the modal. edit: only read now that @chargome raised some of these issues as well |
looks like Mintlify suffers from the same lack of feedback problem and it's ripe for rage clicks should we collect positive feedback for now? @stephanie-anderson |
@a-hariti yes, I'd say let's collect additional feedback on all of the options we offer (even if that's just these two at the moment) |
Wow, I like the changes you've done, @a-hariti ! Additional feedback now is, that I would increase the spacing between the next/previous nav and the feedback a little bit We could also test with
🙏 |
@a-hariti I would go for |
closes #11363